ArchPcode: Report no program counter for a language that declares none. - #367
Open
zardus wants to merge 1 commit into
Open
ArchPcode: Report no program counter for a language that declares none.#367zardus wants to merge 1 commit into
zardus wants to merge 1 commit into
Conversation
Member
Author
|
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS Validation record for head
Note: angr/angr#6804 no longer asserts Caveats: the complete local workspace gate was not rerun on this head — a corpus sweep holds the machine — so the local evidence is the focused runs above plus the 187-architecture comparison. |
Member
|
Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/archinfo_367 |
Dalvik and the DATA languages carry no programcounter tag and no register that
could serve as one, so ArchPcode pointed ip_offset at 0x80000000, an offset no
register occupied. Everything that maps that offset or the name back to a
register failed: registers["ip"] and register_names[ip_offset] raised KeyError,
get_register_by_name("ip") returned None, and translate_register_name returned
the decimal offset.
Leave ip_offset unset instead. Arch already declares it optional, and angr
already guards sp_offset the same way. Of the 187 sleigh languages pypcode
4.0.1.dev0 ships, the 15 that declare no program counter lose the invented
offset and nothing else moves; the other 172 are identical field for field.
The type-checking import of pypcode resolves the four "possibly unbound"
diagnostics the module carried, which the CI typecheck scores against the file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
zardus
force-pushed
the
feature/fix-angr-state-blank-ip
branch
from
August 13, 2026 11:25
a5f11be to
6196611
Compare
zardus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS
Dalvik and the DATA sleigh languages declare no program counter and have no register that could serve as one, so
ArchPcodepointedip_offsetat0x80000000, an offset no register occupied.registers["ip"]andregister_names[ip_offset]raisedKeyError,get_register_by_name("ip")returnedNone, andtranslate_register_namereturned the decimal offset.ip_offsetis now left unset for those languages.Archalready declares it optional, and of the 187 languages pypcode ships only those 15 change: they lose the invented offset, and no other field of any language moves.The regression covers both affected families,
Dalvik:LE:32:DEX_NougatandDATA:LE:64:default.Raised in review of angr/angr#6804, which makes angr tolerate the missing register and carries the end-to-end regression.
Validation: #367 (comment)